Dan Kenigsberg has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26951/4/vdsm/caps.py File vdsm/caps.py: Line 391: Line 392: Line 393: def _getSELinux(): Line 394: selinux = dict() Line 395: selinux['mode'] = str(utils.getSELinuxEnforceMode()) > All the int values that are part of the response are converted to string: right. let us conform. However, have you considered reporting the strings enforcing/permissive/disabled ? I believe it would be easier to understand. Line 396: Line 397: return selinux Line 398: Line 399: Line 393: def _getSELinux(): Line 394: selinux = dict() Line 395: selinux['mode'] = str(utils.getSELinuxEnforceMode()) Line 396: Line 397: return selinux > I think additional level is a good idea because it'd allows us to add more good reason indeed. Line 398: Line 399: Line 400: def get(): Line 401: targetArch = getTargetArch() -- To view, visit http://gerrit.ovirt.org/26951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98e0fcb71e831a76c4584bca46dc58fc4298180f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
