Francesco Romani has posted comments on this change. Change subject: tests: initial tests for vm libvirt callbacks ......................................................................
Patch Set 2: (1 comment) I'll try again to catch this damn core. I'd like to avoid to mess up with the system-wide settings, but seems like this is the last viable approach. http://gerrit.ovirt.org/#/c/27128/2/tests/vmTests.py File tests/vmTests.py: Line 772: 'guestCPUCount': -1} Line 773: Line 774: Line 775: @contextmanager Line 776: def FakeVM(params=None, devices=None, run=False): > I find "run" to be a too-vague term. "runcpu" sounds clearer. Indeed. Will fix. Line 777: with namedTemporaryDir() as tmpDir: Line 778: with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/'), Line 779: (libvirtconnection, 'get', Line 780: lambda x: ConnectionMock())]): -- To view, visit http://gerrit.ovirt.org/27128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059ef6cd42e8cfa03e2891dade00ff21e4c435bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
