Nir Soffer has posted comments on this change. Change subject: profile: Introduce profile decorator ......................................................................
Patch Set 2: Verified+1 Changes: - Raise if you try to start a running profiler. Previously, this was checked only in the profile decorator, and now it is handled lower where it should be. - Make the module thread safe, as now profile may be started and stop from anywhere. This ensure that wrong usage will always raise and never corrupt profiles silently. - Sort imports - Rebase on master, as dependent patch was merged Note: if you stop a profile started by someone else, the other code will not fail when it try to stop non-running profiler. We can raise an error in this case (e.g. "profiler is not running"), but experience tells that trying to be too strict when stopping things is more painful. Verified by running the tests. -- To view, visit http://gerrit.ovirt.org/27389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bc861832bbbda67937b5663f6cfbc1a54bfbf7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
