Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: add the GraphicsDevice class ......................................................................
Patch Set 19: (1 comment) http://gerrit.ovirt.org/#/c/26895/19/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 191: self._vm.setDownStatus(NORMAL, vmexitreason.SAVE_STATE_SUCCEEDED) Line 192: self.status['status']['message'] = 'SaveState done' Line 193: Line 194: def _patchConfigForGraphics(self): Line 195: if 'display' in self._machineParams: > 'display' is dropped for all clusterLevels - as far as I understand this br I'd think so… Only the spice+vnc configs do not need to maintain BC as older vdsms wouldn't understand it in the old way. But if the VM has only one display here we should send it "the old way" The migration of spice+vnc VMs to older cluster levels/vdsms should be prevented on the engine side, in case of vdsClient or bug in engine the migration would fail (which is correct) Line 196: del self._machineParams['display'] Line 197: if 'displayIp' in self._machineParams: Line 198: del self._machineParams['displayIp'] Line 199: -- To view, visit http://gerrit.ovirt.org/26895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
