mooli tayer has posted comments on this change. Change subject: configfile.py utility for common config file editing operations. ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27129/5/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 161: if self.context: Line 162: self.remove = True Line 163: else: Line 164: raise RuntimeError("Must be called from a managed context.") Line 165: > what with the decorator ? ^ I do not follow Line 166: def hasConf(self): Line 167: """ Line 168: Notice this method is called out of context since it is read only Line 169: """ http://gerrit.ovirt.org/#/c/27129/5/tests/toolTests.py File tests/toolTests.py: Line 172 Line 173 Line 174 Line 175 Line 176 > its a bit confusing that you remove those tests in this patch. leave it for Done -- To view, visit http://gerrit.ovirt.org/27129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c7ae2b562650e403fc39024f3531d44b2b9c4f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
