Dan Kenigsberg has posted comments on this change. Change subject: fileUtils: Remove support for direct io on memory filesystems ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27441/1/tests/fileUtilTests.py File tests/fileUtilTests.py: Line 34: data = """Vestibulum. Libero leo nostra, pede nunc eu. Pellentesque Line 35: platea lacus morbi nisl montes ve. Ac. A, consectetuer erat, justo eu. Line 36: Elementum et, phasellus fames et rutrum donec magnis eu bibendum. Arcu, Line 37: ante aliquam ipsum ut facilisis ad.""" Line 38: with temporaryPath(data=data, dir='.') as srcPath: This assumes that the current directory is writable, and is not memory-mapped. I find this particularly worrying since the tests are often run as root. Forcing dir=/var/tmp (maybe inside temporaryPath()) drops the first of these assumptions. Line 39: # two nested withs to be py2.6 friendly. Line 40: with fileUtils.open_ex(srcPath, "dr") as f: Line 41: self.assertEquals(f.read(), data) Line 42: -- To view, visit http://gerrit.ovirt.org/27441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b652b5c78ff8b48a39df2dc57c02496bec666a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
