Francesco Romani has posted comments on this change. Change subject: vm: Modify memory units of numa node ......................................................................
Patch Set 3: (1 comment) One minor style comment, not worth a -1 only for that but please consider. http://gerrit.ovirt.org/#/c/27403/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 724: for vmCell in guestNumaNodes: Line 725: nodeMem = int(vmCell['memory']) * 1024 Line 726: numa.appendChildWithArgs('cell', Line 727: cpus=vmCell['cpus'], Line 728: memory=str(nodeMem)) please consider (and check if pep8 is OK with it) numa.appendChildWithArgs( 'cell', cpus=vmCell['cpus'], memory=str(int(vmCell['memory']) * 1024)) Line 729: cpu.appendChild(numa) Line 730: Line 731: self.dom.appendChild(cpu) Line 732: -- To view, visit http://gerrit.ovirt.org/27403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
