Dan Kenigsberg has posted comments on this change. Change subject: caps: report if QEMU supports live snapshots ......................................................................
Patch Set 8: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26149/8/vdsm/caps.py File vdsm/caps.py: Line 81: PPC64 = 'ppc64' Line 82: Line 83: Line 84: class FeatureStatus: Line 85: ON = 'on' English strings are for humans. We have booleans. True/False/not reported is a cleaner tri-state, that is easier to test, and should be simpler for Engine too (which has to handle old Vdsm that does not report this value at all). Line 86: OFF = 'off' Line 87: UNKNOWN = 'unknown' Line 88: Line 89: Line 214: archTag = guestTag.getElementsByTagName('arch')[0] Line 215: if archTag.getAttribute('name') == arch: Line 216: return _findLiveSnapshotSupport(guestTag) Line 217: Line 218: # we should never get here. so better log an ERROR. Line 219: return FeatureStatus.UNKNOWN Line 220: Line 221: Line 222: @utils.memoized -- To view, visit http://gerrit.ovirt.org/26149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
