Francesco Romani has posted comments on this change. Change subject: vm: drop the display params after device creation ......................................................................
Patch Set 1: Verified+1 Vetrified with http://gerrit.ovirt.org/#/c/26895/ , http://gerrit.ovirt.org/#/c/27596/ and http://gerrit.ovirt.org/#/c/27215/ Verification (all the following using unpatched engine 3.5.0 snapshot: * creation flow: booted a VM, connected with spice * recovery: booted a VM, restarted VDSM, connected with spice * migration: migrated back and forth another host running VDSM 4.14.8.1 * hibernate: booted a VM, restarted and connected with spice. * verified the output of vdsClient * cursory look at vdsm logs and to engine logs seems OK. Found Received a spice Device without an address when processing VM 025d59e3-f12c-41b8-be3f-de8dc22d23ce devices, skipping device: {port=5900, specParams={keyMap=en-us, copyPasteEnable=false, displayIp=0, fileTransferEnable=false}, device=spice, type=graphics} but that is expected since the graphics device do not have PCI addresses. -- To view, visit http://gerrit.ovirt.org/27595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aa8096de1f9d798f6d42d640420efebc2e2c3b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches