Dan Kenigsberg has posted comments on this change. Change subject: virt: graphdev: handle ticket for multiple devices ......................................................................
Patch Set 26: Code-Review-1 (3 comments) two docstring comments http://gerrit.ovirt.org/#/c/26897/26//COMMIT_MSG Commit Message: Line 6: Line 7: virt: graphdev: handle ticket for multiple devices Line 8: Line 9: This patch extends the ticket support for the Line 10: multiple graphics devices scenario. it also adds a completely new usage to the updateDevice API, which deserves an exposition here. Line 11: Line 12: Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 http://gerrit.ovirt.org/#/c/26897/26/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4405: Line 4406: def _reviveTicket(self, newlife): Line 4407: """ Line 4408: Revive an existing ticket, if it has expired or about to expire. Line 4409: Will be called if VM has a SPICE device. please explain why this is irrelevant to vnc devices Line 4410: """ Line 4411: graphics = self._findGraphicsDevice('spice') Line 4412: validto = max(time.strptime(graphics.getAttribute('passwdValidTo'), Line 4413: '%Y-%m-%dT%H:%M:%S'), Line 4418: self._dom.updateDeviceFlags(graphics.toxml(), 0) Line 4419: Line 4420: def _findGraphicsDevice(self, deviceType): Line 4421: """ Line 4422: libvirt (as in 1.2.3) supports only one graphic device per type but can we be a bit more future-compatible that that? Does libvirt plan to provide a unique <alias> for graphic devices? Line 4423: """ Line 4424: for graphics in _domParseStr( Line 4425: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \ Line 4426: childNodes[0].getElementsByTagName('graphics'): -- To view, visit http://gerrit.ovirt.org/26897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62f56ea47399b0d26aafce053ea1201457564b73 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
