Nir Soffer has posted comments on this change. Change subject: fileVolume: avoid full size truncation for cow ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27544/2/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 117: Class specific implementation of volumeCreate. All the exceptions are Line 118: properly handled and logged in volume.create() Line 119: """ Line 120: Line 121: sizeBytes = size * BLOCK_SIZE > It's a good move to trust the caller regarding size being int. But I'd like I suggest to return the int() call in this patch. Line 122: truncSize = sizeBytes if volFormat == volume.RAW_FORMAT else 0 Line 123: Line 124: try: Line 125: oop.getProcessPool(dom.sdUUID).truncateFile(volPath, truncSize, -- To view, visit http://gerrit.ovirt.org/27544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3414459797236b1055d92f33d86baf1fae7f52fd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
