mooli tayer has posted comments on this change. Change subject: replace configure_libvirt.py with python code. ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 98: 'path': os.path.join( Line 99: SYSCONF_PATH, Line 100: 'libvirt/libvirtd.conf' Line 101: ), Line 102: 'configureFunc': 'addSection', > why not just put here the function? not a string the function, you can call This only works if the functions are defined above FILES. maybe I should move those functions to a new class? Line 103: 'removeConfFunc': 'removeSection', Line 104: 'fragments': [ Line 105: { Line 106: 'conditions': {}, -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
