Nir Soffer has posted comments on this change. Change subject: storage: Add logging on filesystem altering operations ......................................................................
Patch Set 7: (2 comments) Now there are just 2 whitespace issues. http://gerrit.ovirt.org/#/c/26046/7/vdsm/storage/fileUtils.py File vdsm/storage/fileUtils.py: Line 380: if (mode & 0o070) != newGroupMode: # group mode mask Line 381: # setting the new group mode masking out the original one Line 382: newMode = (mode & 0o707) | newGroupMode Line 383: log.debug("Changing mode for %s to %#o", path, Line 384: newMode) I think this can fit in the previous line. Line 385: os.chmod(path, newMode) Line 386: Line 387: Line 388: def padToBlockSize(path): Line 389: with file(path, 'a') as f: Line 390: size = os.fstat(f.fileno()).st_size Line 391: newSize = 512 * ((size + 511) / 512) Line 392: log.debug("Truncating file %s to %s", path, Line 393: newSize) Same, join with previous line? -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3602513af123951f71091c03f799e36ea759aa61 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
