Martin Sivák has posted comments on this change. Change subject: Adding "updateVmPolicy" api ......................................................................
Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/27272/14/vdsm/mom.d/04-cputune.policy File vdsm/mom.d/04-cputune.policy: Line 9: ### Helper functions Line 10: (def check_and_set_quota (guest) Line 11: { Line 12: Line 13: (defvar calcQuota (/ (* anchor (/ guest.vcpu_user_limit 100.0)) guest.vcpu_count)) Merge this to the patch that added this file please. Line 14: Line 15: (if (!= guest.vcpu_quota calcQuota) Line 16: (guest.Control "vcpu_quota" calcQuota) 0) Line 17: }) http://gerrit.ovirt.org/#/c/27272/14/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4411: return {} Line 4412: Line 4413: def _getUserCpuTuneInfo(self): Line 4414: ret = {} Line 4415: try: Merge those to the files that added the functionality. Line 4416: domain = self._connection.lookupByUUIDString(self.id) Line 4417: Line 4418: if domain: Line 4419: vcpuLimitUri = 'http://ovirt.org/param/vcpu_limit' http://gerrit.ovirt.org/#/c/27272/14/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 7255: # Set VM SLA parameters Line 7256: # Line 7257: # @vmID: The UUID of the VM Line 7258: # Line 7259: # @vcpuLimit: vcpu limit to set Can you add a description of what the value actually means? OR a link to documentation maybe? Line 7260: # Line 7261: # Returns: Line 7262: # The VM definition, as updated Line 7263: # -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9750667c4d20d7589a1797e65d5683692ec02afe Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
