Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26575/2/lib/vdsm/tool/unified_persistence.py File lib/vdsm/tool/unified_persistence.py: Line 158: Line 159: @expose(UPGRADE_NAME) Line 160: def unified_persistence(*args): Line 161: """ Line 162: unified_persistence [upgrade-options] > I see no usage in *args. Are you sure there are any upgrade-options? This patch makes it happen: http://gerrit.ovirt.org/#/c/27193 Line 163: Upgrade host networking persistence from ifcfg to unified if the Line 164: persistence model is set as unified in /usr/lib64/python2.X/site-packages/ Line 165: vdsm/config.py Line 166: """ http://gerrit.ovirt.org/#/c/26575/2/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 155: Line 156: try: Line 157: return tool_command[cmd]["command"](*args) Line 158: except vdsm.tool.VdsmToolWrongArgsError as e: Line 159: print_command_usage(tool_command[cmd]["command"], sys.stderr) > Use an explicit "return 0" if you consider this as a success case (here and Done Line 160: except vdsm.tool.VdsmToolRuntimeError as e: Line 161: print >> sys.stderr, 'Error:', e Line 162: except Exception: Line 163: traceback.print_exc(file=sys.stderr) -- To view, visit http://gerrit.ovirt.org/26575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I831bde947f451805e086e25f1c0b9943b17e7bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Eylon <yaniv.ey...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
