Antoni Segura Puimedon has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27573/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1392: def updateMonitoringThreads(self): Line 1393: # domain list it's list of sdUUID:status Line 1394: # sdUUID1:status1,sdUUID2:status2,... Line 1395: activeDomains = set(self.getDomains(activeOnly=True)) Line 1396: monitoredDomains = set(self.domainMonitor.poolMonitoredDomains) these both should be frozensets. Line 1397: Line 1398: monitorsToStop = monitoredDomains - activeDomains Line 1399: Line 1400: for sdUUID in monitorsToStop: -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12f137f1ed055316767e1a9384d8982720bc564 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
