Ondřej Svoboda has posted comments on this change. Change subject: network: Reset a bond's options to defaults before using it ......................................................................
Patch Set 12: (1 comment) Why the test failed. http://gerrit.ovirt.org/#/c/26374/12/vdsm/network/models.py File vdsm/network/models.py: Line 239 Line 240 Line 241 Line 242 Line 243 What is the reason for replacing purposedly empty options with the the current state? This way, e.g. testSetupNetworksResizeBond fails with miimon=9 already set for the bond (left over from a previous run of all the tests). If bonds are reused during VDSM’s lifetime (and their options can be changed at will) this is really an issue. -- To view, visit http://gerrit.ovirt.org/26374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884b7436e12df9dc8572694f886a3c7eb32de200 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
