Francesco Romani has posted comments on this change. Change subject: vm: Automatically add a serial port for a console device ......................................................................
Patch Set 6: (1 comment) I agree with Toni here. Spice GraphicsDevices may be another case of composite devices (for spice vmc channels), or anyway a case worth considering. http://gerrit.ovirt.org/#/c/25979/6/tests/vmTests.py File tests/vmTests.py: Line 300: self.assertXML(console.getXML(), consoleXML) Line 301: domxml = vm._DomXML(self.conf, self.log, Line 302: caps.Architecture.X86_64) Line 303: domxml.appendConsoleSerial() Line 304: assert(len(domxml._devices.getElementsByTagName('serial')) == 0) I'd use self.assertFalse for better reporting Line 305: domxml._devices.appendChild(console.getXML()) Line 306: domxml.appendConsoleSerial() Line 307: self.assertXML(domxml._devices, serialXML, 'serial') Line 308: -- To view, visit http://gerrit.ovirt.org/25979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa7b02a7bcaad63017c35c811a194fa42e2b694f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
