Dan Kenigsberg has posted comments on this change. Change subject: storage: Add logging on filesystem altering operations ......................................................................
Patch Set 9: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/26046/9/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 388: raise se.ImageDeleteError("%s %s" % (imgUUID, str(e))) Line 389: for volUUID in volsImgs: Line 390: volPath = os.path.join(toDelDir, volUUID) Line 391: try: Line 392: self.log.debug("Removing file: %s", volPath) this could have been kept out easily, but never mind. Line 393: self.oop.os.remove(volPath) Line 394: metaFile = volPath + '.meta' Line 395: self.log.debug("Removing file: %s", metaFile) Line 396: self.oop.os.remove(metaFile) -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3602513af123951f71091c03f799e36ea759aa61 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Xavi Francisco <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
