Antoni Segura Puimedon has posted comments on this change.
Change subject: Pyroute2 network configurator
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Only two very small changes are required. To fix them, please do:
git fetch git://gerrit.ovirt.org/vdsm refs/changes/45/27745/1 && git
checkout FETCH_HEAD
edit vdsm/network/configurators/pyroute_two.py and make the requested changes.
git add vdsm/network/configurators/pyroute_two.py
git commit --amend
git push gerrit.ovirt.org:vdsm HEAD:refs/for/master/pyroute_two
With this it should not create a new patchset, but just update the current one.
Making this configurator selectable will come in a later patch by me.
http://gerrit.ovirt.org/#/c/27745/1/vdsm/network/configurators/pyroute_two.py
File vdsm/network/configurators/pyroute_two.py:
Line 32: 'ethtool',
Line 33: '/usr/sbin/ethtool', # F19+
Line 34: '/sbin/ethtool', # EL6, ubuntu and Debian
Line 35: '/usr/bin/ethtool', # Arch
Line 36: )
You are not using in _ETHTOOL_BINARY in the rest of the configurator, so it
should be removed from here.
Line 37:
Line 38:
Line 39: class PyrouteTwo(Iproute2):
Line 40: def __init__(self, inRollback=False):
Line 49:
Line 50:
Line 51: class ConfigApplier(object):
Line 52: def __init__(self):
Line 53: self.ip = IPDB(fork=True)
> pls discuss with Antoni, if it would be better to remove «fork=True» — sinc
I'd like it removed, yes.
Line 54:
Line 55: def _setIpConfig(self, iface):
Line 56: ipConfig = iface.ipConfig
Line 57: if ipConfig.ipaddr:
--
To view, visit http://gerrit.ovirt.org/27745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1ba6fca28f04bc1b171313bfb57bf630f8bc7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Robert Cernak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Robert Cernak <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
