Nir Soffer has posted comments on this change. Change subject: profile: Support yappi builtins option ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27787/2/tests/profileTests.py File tests/profileTests.py: Line 94: profile.start() Line 95: dict() Line 96: profile.stop() Line 97: out = read_pstats(FILENAME) Line 98: self.assertIn('__builtin__:0', out) I hate this way of testing, but it was way faster then understand how to iterate on the contents of yappi.YFuncStats object. I'll check how to do this in a later patch. Line 99: Line 100: @MonkeyPatch(profile, 'config', make_config(enable='true')) Line 101: @MonkeyPatch(profile, '_FILENAME', FILENAME) Line 102: @MonkeyPatch(profile, '_FORMAT', 'pstat') -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
