Michal Skrivanek has posted comments on this change. Change subject: keep pauseCode when migrating paused VM ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27801/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1957: if migrating and self.lastStatus != vmstatus.DOWN: Line 1958: self._waitForIncomingMigrationFinish() Line 1959: Line 1960: self.lastStatus = vmstatus.UP Line 1961: if self._initTimePauseCode: > I noticed that part of course, it doesn't do anything in case of migration I think the current code is broken. E.g. for the regular Run - we do this in domDependentInit(via _run): if self.lastStatus not in (vmstatus.MIGRATION_DESTINATION, vmstatus.RESTORING_STATE): <we get here> self._initTimePauseCode = self._readPauseCode(0) <readPauseCode always returns "NOERR"> if not self.recovering and self._initTimePauseCode: self.conf['pauseCode'] = self._initTimePauseCode <i.e. we always set the pauseCode to NOERR> and now we are removing the pause code in almost all cases. And it gets even more confusing when you track _initTimePauseCode. Line 1962: self.conf['pauseCode'] = self._initTimePauseCode Line 1963: if self._initTimePauseCode == 'ENOSPC': Line 1964: self.cont() Line 1965: elif not migrating: -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iead0697bbebba3f261040221b04cd3745d8ef036 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
