Michal Skrivanek has posted comments on this change. Change subject: always teardown snapshot's memory volume ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3649: # is to prevent spurious libvirt errors about missing drive paths Line 3650: # (since we're changing them), and also to prevent to trigger a drive Line 3651: # extension for the new volume with the apparent size of the old one Line 3652: # (the apparentsize is updated as last step in updateDriveParameters) Line 3653: self.stopDisksStatsCollection() > I'm not sure, but I see that it is also called from diskReplicateFinish whi Federico, what do you say? Why is it ok to stop stats during live-storage-migration? Line 3654: Line 3655: try: Line 3656: try: Line 3657: self._dom.snapshotCreateXML(snapxml, snapFlags) -- To view, visit http://gerrit.ovirt.org/26544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59047f7d5ba6cfa942b593683f6f9987619a7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
