mooli tayer has posted comments on this change. Change subject: replace configure_libvirt.py with python code. ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/27298/12/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 121: self._getPersistedFiles() Line 122: ): Line 123: ovirtfunctions.ovirt_store_config(path) Line 124: Line 125: sys.stdout.write("Reconfiguration of libvirt is done.") > remove this print and update the print "def configure()" with modules' name ok. here: http://gerrit.ovirt.org/#/c/27841/ Line 126: Line 127: def validate(self): Line 128: """ Line 129: Validate conflict in configured files Line 311: with self._openConfig(path) as conff: Line 312: conff.removeConf() Line 313: Line 314: FILES = { Line 315: > I would put the CONF_VERSION aside the configuration and state that modific Done Line 316: # Vdsm configuration Line 317: Line 318: 'VDSM_CONF': { Line 319: 'path': os.path.join( http://gerrit.ovirt.org/#/c/27298/12/vdsm.spec.in File vdsm.spec.in: Line 749: removeConf > it's called remove-config Thanks. done -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
