Nir Soffer has posted comments on this change. Change subject: sampling: use constants for counter bounds ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24194/1/vdsm/sampling.py File vdsm/sampling.py: Line 43: _THP_STATE_PATH = '/sys/kernel/mm/redhat_transparent_hugepage/enabled' Line 44: Line 45: JIFFIES_BOUND = 2 ** 32 Line 46: NETSTATS_BOUND = 2 ** 32 Line 47: > I find BOUND as a better term than MAX, since INT_MAX is a valid value for Lets fight later about the names :-) Line 48: Line 49: class InterfaceSample: Line 50: """ Line 51: A network interface sample. -- To view, visit http://gerrit.ovirt.org/24194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
