Francesco Romani has posted comments on this change. Change subject: stats: avoid log if cpu stats are known missing ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27416/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 284: - self._diff(eInfo, sInfo, 'system_time'), Line 285: sampleInterval) Line 286: Line 287: except (TypeError, ZeroDivisionError) as e: Line 288: self._log.debug("CPU stats not available: %s", e) > What about this patch just be a modification above: We want to avoid to add logs if sInfo is None, because this one of the known and benign cases on which samples are not available: not enough samples collected. Line 289: Line 290: @classmethod Line 291: def _getNicStats(cls, name, model, mac, Line 292: start_sample, end_sample, interval): -- To view, visit http://gerrit.ovirt.org/27416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62eff2e04a2922fb683d3c1d78605990399c7b76 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
