Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG Commit Message: Line 13: alternative method of shutdown/reboot. Line 14: Line 15: If 'force' is True and all graceful methods fail, we reset/destroy the VM. Line 16: Line 17: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054070 > Sorry, I'm having quite an hard time to see how this change helps with Well the refactoring to callback chain was necessary to the development of reboot detection and since this is a follow-up patch to the callback chain, this bug is suitable (albeit not obvious at first sight) Line 18: Change-Id: I30180f9906eb45fa485aa7d773a436e62bd3c815 -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30180f9906eb45fa485aa7d773a436e62bd3c815 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
