Dan Kenigsberg has posted comments on this change. Change subject: task: prevent tasks with the same id to be queued ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26808/2/vdsm/storage/taskManager.py File vdsm/storage/taskManager.py: Line 58: Line 59: try: Line 60: if not self.tp.queueTask(task.id, method): Line 61: self.log.error("unable to queue task: %s", task.dumpTask()) Line 62: del self._tasks[task.id] > Done Protecting only this place would not be consistent - there are many other places we delete tasks from that dictionary. It would be just as safe to project only the insertion operation, instead of introducing a overall protection of the dictionary object. Line 63: raise se.AddTaskError() Line 64: self.log.debug("task queued: %s", task.id) Line 65: except Exception: Line 66: self.log.exception('could not queue task %s', task.id) -- To view, visit http://gerrit.ovirt.org/26808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9980de08d10203a75071dae9b16c9b850a91f5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
