Vinzenz Feenstra has posted comments on this change. Change subject: faqemu: move hook logic out of vdsm ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27705/3/vdsm_hooks/faqemu/after_get_caps.py File vdsm_hooks/faqemu/after_get_caps.py: Line 26: # using vdsm internals in a hook is dangerous and frowned upon, Line 27: # as internal APIs may change without notice. Line 28: # However, faqemu is a bit different, as it is not expected to be ever used in Line 29: # production. Line 30: sys.path.append('/usr/share/vdsm') > I'm still not convinced about this hardcoded path. This should be a @@ variable and this file should be a .in file. Line 31: import caps Line 32: import hooking Line 33: from vdsm.config import config Line 34: -- To view, visit http://gerrit.ovirt.org/27705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46d0079491f707b0abd3fbbe2d47f63697dac9c5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
