Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/26300/18/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 84: return None Line 85: Line 86: def add_json_binding(self, jsonBinding): Line 87: self._jsonBinding = jsonBinding Line 88: self._jsonBinding.start() Why do you start the binding here? It seems better than somebody else will be responsible for starting and stopping bindings, and handle you a ready object. I don't see hy multiple-protocol acceptor has to manage the lifetime of the it uses. This makes code much easier to test and change - see how HSM is object is created now in vdsm/vdsm script. Line 89: Line 90: def add_xml_binding(self, xmlBinding): Line 91: self._xmlBinding = xmlBinding Line 92: self._xmlBinding.start() -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
