Dan Kenigsberg has posted comments on this change. Change subject: vm: Create vm numa node according to the node index ......................................................................
Patch Set 1: Code-Review-1 (2 comments) /me is joining Martin's request; such requests should be accompanied with a -1. "-1" is not an insult, it is a polite way to say "I believe this patch is not ready yet". http://gerrit.ovirt.org/#/c/27987/1/tests/vmTests.py File tests/vmTests.py: Line 359: vmConf = {'cpuType': "Opteron_G4,+sse4_1,+sse4_2,-svm", Line 360: 'smpCoresPerSocket': 2, 'smpThreadsPerCore': 2, Line 361: 'cpuPinning': {'0': '0-1', '1': '2-3'}, Line 362: 'numaTune': {'mode': 'strict', 'nodeset': '0-1'}, Line 363: 'guestNumaNodes': [{'cpus': '0,1', 'memory': '5120', are the ranges illegal to use? what should match what, and how? please explain in the commit message. Line 364: 'nodeIndex': 0}, Line 365: {'cpus': '2,3', 'memory': '5120', Line 366: 'nodeIndex': 1}]} Line 367: vmConf.update(self.conf) http://gerrit.ovirt.org/#/c/27987/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 20: Line 21: Line 22: # stdlib imports Line 23: from contextlib import contextmanager Line 24: from copy import deepcopy please place new import in place Line 25: from xml.dom import Node Line 26: from xml.dom.minidom import parseString as _domParseStr Line 27: import logging Line 28: import os -- To view, visit http://gerrit.ovirt.org/27987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I622e561a72fced21f0655c5de0ea520adfb0612a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
