Federico Simoncelli has posted comments on this change. Change subject: virt: Lookup conf and device by path ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/27951/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3081: if dev.path == path: Line 3082: return dev Line 3083: except AttributeError: Line 3084: continue Line 3085: raise LookupError('Device instance for device with path %s not found' % We should use the new format: 'Device instance for device with path {0} not found'.format(path) Line 3086: path) Line 3087: Line 3088: def _lookupConfByPath(self, path): Line 3089: for devConf in self.conf['devices'][:]: Line 3089: for devConf in self.conf['devices'][:]: Line 3090: if devConf.get('path') == path: Line 3091: return devConf Line 3092: raise LookupError('Configuration of device with path %s not found' % Line 3093: path) Same here. Line 3094: Line 3095: def _updateInterfaceDevice(self, params): Line 3096: try: Line 3097: netDev = self._lookupDeviceByAlias(NIC_DEVICES, params['alias']) -- To view, visit http://gerrit.ovirt.org/27951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f63715cd5142ffaf21ae9ba8d451175ae09be0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
