Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: add unprefixLines() to configfile.py. ......................................................................
vdsm-tool: add unprefixLines() to configfile.py. New method removes 'prefix' from each line starting with it. No editing is done on new content added by this config file. This method will be used to remove '# VDSM backup' comments put inside libvirt logrotate file. Changed doc string of prefixLines to reflect the link between the two methods. Tests included (see testPrefixIdempotencey in toolTests.py). unprefixLines is the reverse function of prefixLines so that unprefixLines(prefixLines(file)) = file. Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Signed-off-by: Mooli Tayer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/27737 Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configfile.py M tests/toolTests.py 2 files changed, 53 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd869dced51f1e67c9fb1bb264424b3758cc54f0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
