Dan Kenigsberg has posted comments on this change. Change subject: tests: use 'localhost' explicitly in test ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28107/1/tests/functional/storageTests.py File tests/functional/storageTests.py: Line 79: isSSL = config.getboolean('vars', 'ssl') Line 80: if isSSL and os.geteuid() != 0: Line 81: raise SkipTest("Must be root to use SSL connection to server") Line 82: address = 'localhost:%s' % config.get('addresses', 'management_port') Line 83: self.s = vdscli.connect(hostPort=address, useSSL=isSSL) > Having heuristic for connect is bad idea, and we don't want to use this mis pushing heuristics down to vdscli might have been bad and misguided. I can agree to this. But if instead of fixing it you add a contradicting heuristic here, one should at least explain what's broken at the moment. I believe that with this patch, hosts with ssl=True and non-self signed certs would fail to run. Line 84: Line 85: def assertVdsOK(self, vdsResult): Line 86: # code == 0 means OK Line 87: self.assertEquals( -- To view, visit http://gerrit.ovirt.org/28107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89990cff46e64120262e250eee9238b49c4edee4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
