Daniel Erez has posted comments on this change. Change subject: vm: wrong message formatting leads to an exception ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28132/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3939: try: Line 3940: self._setDiskReplica(srcDrive, dstDisk) Line 3941: except Exception: Line 3942: self.log.error("Unable to set the replication for disk '%s' with " Line 3943: "destination '%s'" % (srcDrive.name, dstDisk)) > This works but not the correct fix. When using logging, we should let the Sure, I actually prefer that way as well :) Line 3944: return errCode['replicaErr'] Line 3945: Line 3946: dstDiskCopy = dstDisk.copy() Line 3947: -- To view, visit http://gerrit.ovirt.org/28132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib789adb51cd4ca112489d55b6e10f69698a4a3ac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
