Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed ......................................................................
Patch Set 8: Code-Review-1 (2 comments) Thanks for the patch, I will check it with my bonding options patch, using ifcfg configurator. For now, it failed to build because of 'Bond being imported, but unused'. http://gerrit.ovirt.org/#/c/28062/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1940: network[NETWORK_NAME]['ipaddr']) Line 1941: self.assertEqual(len( Line 1942: self.vdsm_net.netinfo.bondings[BONDING_NAME]['ipv4addrs']), 1) Line 1943: Line 1944: # Redefine the ip address What is the motivation for changing the address twice? Line 1945: network[NETWORK_NAME]['ipaddr'] = '1.1.1.3' Line 1946: status, msg = self.vdsm_net.setupNetworks(network, bonds, NOCHK) Line 1947: self.assertEqual(status, SUCCESS, msg) Line 1948: self.assertNetworkExists(NETWORK_NAME) http://gerrit.ovirt.org/#/c/28062/8/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 38: from vdsm.netconfpersistence import RunningConfig Line 39: Line 40: from . import Configurator, dhclient, getEthtoolOpts, libvirt Line 41: from ..errors import ConfigNetworkError, ERR_FAILED_IFUP Line 42: from ..models import Nic, Bond, Bridge, IpConfig In this revision, Bond is unused, please remove it :-) Line 43: from ..sourceroute import StaticSourceRoute, DynamicSourceRoute Line 44: import dsaversion # TODO: Make parent package import when vdsm is a package Line 45: Line 46: -- To view, visit http://gerrit.ovirt.org/28062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
