Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection ......................................................................
Patch Set 24: (2 comments) http://gerrit.ovirt.org/#/c/26300/24/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 897: (self.setupNetworks, 'setupNetworks'), Line 898: (self.ping, 'ping'), Line 899: (self.setSafeNetworkConfig, 'setSafeNetworkConfig'), Line 900: (self.fenceNode, 'fenceNode'), Line 901: (self.stop, 'prepareForShutdown'), Nice! I hated that name - but why the string is not updated? Line 902: (self.setLogLevel, 'setLogLevel'), Line 903: (self.setMOMPolicy, 'setMOMPolicy'), Line 904: (self.setMOMPolicyParameters, 'setMOMPolicyParameters'), Line 905: (self.setHaMaintenanceMode, 'setHaMaintenanceMode'), Line 1060: try: Line 1061: method, rest = data.split(" ", 1) Line 1062: except ValueError: Line 1063: return False Line 1064: return method == "POST" and rest.startswith("/RPC2") Need to check with engine that all rpc calls do use "/RPC2", and not "/" - critical. Line 1065: Line 1066: def handleSocket(self, client_socket, socket_address): Line 1067: self.xml_binding.add_socket(client_socket, socket_address) Line 1068: self.log.debug("xml over http detected from %s", socket_address) -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
