Antoni Segura Puimedon has posted comments on this change. Change subject: vm: graphdev: rename a parameter for clarity ......................................................................
Patch Set 3: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/28036/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-05-26 11:55:59 +0200 Line 6: Line 7: vm: graphdev: rename a parameter for clarity Line 8: Line 9: The multiple updateDevice API for grpahics device s/grpahics/graphics/ Line 10: has not clients yet, so this patch changes the naming Line 11: to make one parameter more self-explanatory. Line 12: Line 13: As nice side effect, this allows a cleaner and shorter Line 6: Line 7: vm: graphdev: rename a parameter for clarity Line 8: Line 9: The multiple updateDevice API for grpahics device Line 10: has not clients yet, so this patch changes the naming s/not/no/ Line 11: to make one parameter more self-explanatory. Line 12: Line 13: As nice side effect, this allows a cleaner and shorter Line 14: implementation. http://gerrit.ovirt.org/#/c/28036/3/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 6262: ## Line 6263: {'type': 'vmUpdateGraphicsDeviceParams', Line 6264: 'data': {'graphicsType': 'VmGraphicsDeviceType', 'password': 'str', Line 6265: 'ttl': 'int', 'existingConnAction': 'VmTicketConflictAction', Line 6266: 'hookParams': 'StringMap'}} I'm not sure about this. If I'm not mistaken, in the rest of the API, the hooks use the specParams of the device itself to have extra data. Line 6267: Line 6268: ## Line 6269: # @VM.updateDevice: Line 6270: # -- To view, visit http://gerrit.ovirt.org/28036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3716b48a5fbe5beebb819754d0f500b097f04677 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
