Liron Ar has posted comments on this change. Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28264/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1465: # vars.task.setDefaultException(se.ChangeMeError("%s" % args)) Line 1466: pool = self.getPool(spUUID) Line 1467: dom = sdCache.produce(sdUUID=sdUUID) Line 1468: Line 1469: vars.task.getExclusiveLock(STORAGE, "%s_%s", imgUUID, sdUUID) making this change only here will remove the synchronization with other flows that still takes the lock only by the image id only and will let them run while removing. Line 1470: vars.task.getSharedLock(STORAGE, sdUUID) Line 1471: allVols = dom.getAllVolumes() Line 1472: volsByImg = sd.getVolsOfImage(allVols, imgUUID) Line 1473: if not volsByImg: -- To view, visit http://gerrit.ovirt.org/28264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057b1f680276b1eb8a5d910260b7db4c4236fbf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
