Nir Soffer has posted comments on this change. Change subject: http protocol detection ......................................................................
Patch Set 5: Code-Review-1 Thinking more about it, we cannot use this to separate the xmlrpc and http servers. Protocol detection assume that the first request represent all requests on some connection, so if I got an xmlrpc request, all other requests on this connection will be xmlrpc. This assumption is wrong as the same connection can be used by the engine for both xmlrpc and http. Since we must support old engine, this can not be solved by using different connection pools on the engine side in future engine versions. -- To view, visit http://gerrit.ovirt.org/27839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f899cbab4d95ebd184bf32f3ccec1f4fa0e49bc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
