Federico Simoncelli has posted comments on this change. Change subject: oop: Add an option to configure oop implementation ......................................................................
Patch Set 15: Code-Review-1 (1 comment) Please remove the unneeded attribute. http://gerrit.ovirt.org/#/c/26576/15/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 68: class _ModuleWrapper(types.ModuleType): Line 69: def __init__(self, modName, procPool, ioproc, timeout, subModNames=()): Line 70: self._modName = modName Line 71: self._procPool = procPool Line 72: self._iop = ioproc This is not used (not even in the following patches). Line 73: self._timeout = timeout Line 74: Line 75: for subModName in subModNames: Line 76: subSubModNames = [] -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches