Dan Kenigsberg has posted comments on this change. Change subject: faqemu hook: move memory limitation to config ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28320/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-03 12:16:37 +0200 Line 6: Line 7: faqemu hook: move memory limitation to config Line 8: Line 9: Qemu supports more than 20 MB memory[1], removing the need for hardcoded Your patch seems fine, but the commit message is misleading. The memory limit of faqemu is unrelated to [1]. It was simply a means to start the least-costly qemu process - which cannot even run any meaningful guest. That's why it's only a "fake" qemu. This patch makes it possible to have true guests running in emulating (non-virtualizing) qemu, by adhering to Engine-supplied memory size. That's fine. Line 10: memory limit. This patch allows faqemu memory to be either unchanged, Line 11: or limited by the configuration file. Usage of > 20 MB memory is required Line 12: when running faqemu with system kernel/initramfs combo. Line 13: http://gerrit.ovirt.org/#/c/28320/1/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 182: Line 183: ('fake_kvm_architecture', 'x86_64', Line 184: 'Choose the target architecture of the fake KVM mode'), Line 185: Line 186: ('fake_kvm_memory', '262144', None), this changes the default behavior for x86_64 users of faqemu; their processes would start consuming 10 times more memory. We could notify them, and have them edit vdsm.conf before usage. Alternatively, we could set fake_kvm_memory.x86_64 and fake_kvm_memory.ppc64 to maintain current behaviour. Also, please avoid (very natural) laziness, and document any new variable such as this (the third tuple element is intended for that). Line 187: Line 188: ('xmlrpc_enable', 'true', 'Enable the xmlrpc server'), Line 189: Line 190: ('xmlrpc_http11', 'true', -- To view, visit http://gerrit.ovirt.org/28320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ffeaf7926dac2a0db0bdfb21416919452718531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches