Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: refactor: open a new connection in special function ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28348/1/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 77: __connectionLock = threading.Lock() Line 78: Line 79: Line 80: def _open_qemu_connection(): Line 81: def req(credentials, user_data): > _ before? or is it obvious from being inside a func? yes - locally-defined functions and variables do not need the underscore prefix as they are inherently local. Line 82: passwd = file(constants.P_VDSM_LIBVIRT_PASSWD).readline().rstrip("\n") Line 83: for cred in credentials: Line 84: if cred[0] == libvirt.VIR_CRED_AUTHNAME: Line 85: cred[4] = constants.SASL_USERNAME -- To view, visit http://gerrit.ovirt.org/28348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33f83d20d1906dcba7b3652abaeddcba14bec6c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
