Nir Soffer has posted comments on this change. Change subject: Allow GZIP transport on XMLRPC ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25201/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 195: # the methods only on Python 2.6. Line 196: Line 197: if sys.version_info[:2] == (2, 6): Line 198: def __init__(self, *args, **kwargs): Line 199: self.encode_threshold = 1400 > what is this magic number? Can we have a descriptive _CONSTANT instead? Doe 1400 is probbaly the max payload size that can go in one packet using typical MTU. There is no point to compress if we are sending one packet anyway, right? Line 200: SimpleXMLRPCRequestHandler.__init__(self, *args, **kwargs) Line 201: Line 202: # a re to match a gzip Accept-Encoding Line 203: aepattern = re.compile(r""" -- To view, visit http://gerrit.ovirt.org/25201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdaa04b17e2c1df1c1852ed536c5d6d8ec8d88b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
