Kobi Ianko has posted comments on this change.

Change subject: Adding utility methods and conf for CPU limit MOM integration
......................................................................


Patch Set 32:

(1 comment)

http://gerrit.ovirt.org/#/c/27258/32/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 311:     def _getCpuTuneInfo(self, stats):
Line 312:         ret = {}
Line 313:         try:
Line 314:             if self._dom:
Line 315:                 ret = self._dom.schedulerParameters()
> You must not access the _dom object within the context of getAllVmStats, as
Done
Line 316: 
Line 317:                 if ret['vcpu_quota'] is None:
Line 318:                     ret['vcpu_quota'] = -1
Line 319: 


-- 
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to