Alon Bar-Lev has posted comments on this change. Change subject: utils: add ovirt-node persistence functions ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1234: glob.glob('/etc/ovirt-node-*-release') Line 1235: ) Line 1236: Line 1237: Line 1238: def ovirtNodePersist(files): > The function should operate on a single file. the reason was not to check the node each time and not to import the ovirtfunctions each time. please confirm again your request. Line 1239: if isOvirtNode(): Line 1240: from ovirtnode import ovirtfunctions Line 1241: for f in files: Line 1242: if not ovirtfunctions.is_persisted(f): -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
