Alon Bar-Lev has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 825: Line 826: if ret == 0 and 'Not' not in out: Line 827: # Avoid error string - 'Not Settable' or 'Not Present' Line 828: __hostUUID = out.strip() Line 829: elif force: > it is valid way to sign UUID to host for now. later we'll find better uniqu yes, the firmware of ppc have different nature/format, it is serial number based. Line 830: hostid = str(uuid.uuid4()) Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f: Line 832: f.write("%s\n", hostid) Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID]) Line 827: # Avoid error string - 'Not Settable' or 'Not Present' Line 828: __hostUUID = out.strip() Line 829: elif force: Line 830: hostid = str(uuid.uuid4()) Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f: > return None it is count as failure in that part, so i prefer it cleaner no... None is not failure == no uuid, it is supported by legacy and should be continue to be so. Line 832: f.write("%s\n", hostid) Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID]) Line 834: __hostUUID = hostid Line 835: else: -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
