Nir Soffer has posted comments on this change. Change subject: storage: check if mount specification is a symlink ......................................................................
Patch Set 2: > There is a corner case when your code will not do the right thing. It is > quite unlikely to be used, but it still possible: if you mount /dev/./sda1 in > /proc/mounts you'll have the normalized path instead, so /dev/sda1. self.fs_spec is already normlized in Mount.__init__ - so this code should work in this case. > Should I rebase this patch match your change? Since the patch was not finished yet, and you don't need it for an older version, rebasing on master would make it easier to review and verify. -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32aa019b52c28377c064966684986d20414df6db Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Enrico Tagliavini <enrico.tagliav...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Enrico Tagliavini <enrico.tagliav...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
