Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: ssl related code moved to single module ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28506/3/lib/vdsm/SecureXMLRPCServer.py File lib/vdsm/SecureXMLRPCServer.py: Line 185: transport=vtransport) Line 186: print s.add(2, 3) Line 187: Line 188: if __name__ == '__main__': Line 189: import sys > Wouldn't be better to have a unit test for it? Yep. Something that is run continuously would be much better. Line 190: if len(sys.argv) == 1: Line 191: __Test().client() Line 192: else: http://gerrit.ovirt.org/#/c/28506/3/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 23: Line 24: from betterAsyncore import \ Line 25: Dispatcher, \ Line 26: SSLDispatcher Line 27: from vdsm.sslutils import SSLContext > The idea is to evolve dependencies. This phase we want to required both xml Yeah, but yajsonrpc itself could be spun off as an independent module. Line 28: Line 29: Line 30: _STATE_LEN = "Waiting for message length" Line 31: _STATE_MSG = "Waiting for message" -- To view, visit http://gerrit.ovirt.org/28506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If941d90edc08e37e6c0707f3f3bc30f517f9e8eb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
