Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/25976/17/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 426: return 100 Line 427: progress = 100 - 100 * remaining / total if total else 0 Line 428: return progress if (progress < 100) else 99 Line 429: Line 430: if step % self._MONITOR_INTERVAL == 0: > 0 is still a documented value, but it is going to cause ZeroDivisionError i Right, but this code it is supposed to get called if self.enabled, which will ensure _MONITOR_INTERVAL is > 0. What I mean here is to actually run the body only once every _MONITOR_INTERVAL secs, while 1 MONITOR_TICK is one second. Lastly, I haven't checked AdvancedStatsFunction. Will do ASAP. Line 431: (jobType, timeElapsed, _, Line 432: dataTotal, dataProcessed, dataRemaining, Line 433: memTotal, memProcessed, memRemaining, Line 434: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo() -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches